[
https://issues.apache.org/jira/browse/FLINK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597926#comment-16597926
]
Nico Kruber edited comment on FLINK-10142 at 8/30/18 9:07 PM:
--------------------------------------------------------------
Fixed via:
- master: c7ddb0a6cd4edfbf95471950c497e2592d4fdf8f
- release-1.6: 4cf197ede67dee9c4fbb41a4c5a8a61b40ddfa5d
- release-1.5: 9ae5009b6a82248bfae99dac088c1f6e285aa70f
was (Author: nicok):
Fixed via:
- master: 6c7603724be6c146cfc8019b77b60236d1d3d582
- release-1.6: 4cf197ede67dee9c4fbb41a4c5a8a61b40ddfa5d
- release-1.5: 9ae5009b6a82248bfae99dac088c1f6e285aa70f
> Reduce synchronization overhead for credit notifications
> --------------------------------------------------------
>
> Key: FLINK-10142
> URL: https://issues.apache.org/jira/browse/FLINK-10142
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.6.0, 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> When credit-based flow control was introduced, we also added some checks and
> optimisations for uncommon code paths that make common code paths
> unnecessarily more expensive, e.g. checking whether a channel was released
> before forwarding a credit notification to Netty. Such checks would have to
> be confirmed by the Netty thread anyway and thus only add additional load for
> something that happens only once (per channel).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
