[ 
https://issues.apache.org/jira/browse/FLINK-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663178#comment-14663178
 ] 

James Cao commented on FLINK-2444:
----------------------------------

Hi Fabian,

Thanks for your explanation,  if I understood correctly. The goal of the 
supposed test is to verify the inputFormat's methods are called in correct 
order during the life circle of a DataSet. For example (in pseudo code)
{quote}
...
HadoopInputFormat h = new HadoopInputFormat(WrappedFormat, k, v, Job)
DataSet d= env.createInput(h)
d.collect()
...
{quote}
During this flink task, the test code verify the order of the following events 
for WrappedFormat.
bq. 
configure()->getSplits()->reflection-construction->configure()->getRecordReader()
And also for WrappedInputSplits, there is a similar checking for orders of the 
WrappedInputSplits's methods. Is this correct?

I'd like to work on this issue as a process to getting familiar with the flink 
code base. But since this is a major issue, please don't assign me to the issue 
so that we don't prevent other people with more knowledge of it from resolving 
it in a more timely manner .

Thanks!


> Add tests for HadoopInputFormats
> --------------------------------
>
>                 Key: FLINK-2444
>                 URL: https://issues.apache.org/jira/browse/FLINK-2444
>             Project: Flink
>          Issue Type: Test
>          Components: Hadoop Compatibility, Tests
>    Affects Versions: 0.10, 0.9.0
>            Reporter: Fabian Hueske
>              Labels: starter
>
> The HadoopInputFormats and HadoopInputFormatBase classes are not sufficiently 
> covered by unit tests.
> We need tests that ensure that the methods of the wrapped Hadoop InputFormats 
> are correctly called. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to