[
https://issues.apache.org/jira/browse/FLINK-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598730#comment-16598730
]
ASF GitHub Bot commented on FLINK-10208:
----------------------------------------
TisonKun commented on a change in pull request #6634: [FLINK-10208][build] Bump
mockito to 2.21.0 / powermock to 2.0.0-beta.5
URL: https://github.com/apache/flink/pull/6634#discussion_r214349501
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendSavepointTest.java
##########
@@ -315,7 +315,7 @@ private static void restoreStdOutAndStdErr() {
private static ClusterClient<String> createClusterClient(String
expectedResponse) throws Exception {
final ClusterClient<String> clusterClient =
mock(ClusterClient.class);
- when(clusterClient.triggerSavepoint(any(JobID.class),
anyString()))
+ when(clusterClient.triggerSavepoint(any(JobID.class),
nullable(String.class)))
Review comment:
@zentol What is the preference between `nullable(<any>)` and `any(<class>)`?
Inconsistent on this, take a look at `HadoopOutputFormatTest.java` where change
`any(FileSystem.class)` to `nullable(FileSystem.class)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Bump mockito to 2.0+
> --------------------
>
> Key: FLINK-10208
> URL: https://issues.apache.org/jira/browse/FLINK-10208
> Project: Flink
> Issue Type: Sub-task
> Components: Build System, Tests
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Mockito only properly supports java 9 with version 2. We have to bump the
> dependency and fix various API incompatibilities.
> Additionally we could investigate whether we still need powermock after
> bumping the dependency (which we'd also have to bump otherwise).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
