azagrebin commented on a change in pull request #6567: [FLINK-10074] Allowable
number of checkpoint failures
URL: https://github.com/apache/flink/pull/6567#discussion_r214379864
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/CheckpointExceptionHandlerFactory.java
##########
@@ -37,7 +37,7 @@ public CheckpointExceptionHandler
createCheckpointExceptionHandler(
Environment environment) {
if (failTaskOnCheckpointException) {
- return new FailingCheckpointExceptionHandler();
+ return new
FailingCheckpointExceptionHandler(environment);
Review comment:
I think we do not really need `environment` in the constructor of
`FailingCheckpointExceptionHandler`, but only `tolerableNumber` which should be
passed in `createCheckpointExceptionHandler`, the same way as
`failTaskOnCheckpointException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
