zentol opened a new pull request #6663:  [FLINK-10209][build] Exclude jdk.tools 
dependency from hadoop 
URL: https://github.com/apache/flink/pull/6663
 
 
   ## What is the purpose of the change
   
   This PR excludes the `jdk.tools` dependency from hadoop when building with 
java 9. This dependency is for the `tools.jar` that was distributed in jdk8 and 
below, but no longer present in jdk9+.
   
   ## Brief change log
   
   * add `java9` profile that is automatically activated when using java 9
   * add `dependencyManagement` entry for `hadoop-common` that excludes the 
`jdk.tools` dependency
   * restrict `japicmp` plugin to flink artifacts
     * This change was necessary since the plugin apparently looks at all 
artifacts defined in the pom. The added `hadoop-common` entry in the 
`dependencyManagement` has no version attached and thus can't be resolved on 
it's own in non-hadoop modules, which always caused the build to fail. 
Explicitly filtering for flink modules appears to fix this.
   
   ## Verifying this change
   
   Use `mvn help:active-profiles` to verify that the profile is not activated 
on java 8 but on java 9.
   
   I ran this commit (along with other prerequisites for java 9) here: 
https://travis-ci.org/zentol/flink/builds/423911810
        

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to