dawidwys closed pull request #6632: [FLINK-10254][backend]Fix inappropriate 
checkNotNull in stateBackend
URL: https://github.com/apache/flink/pull/6632
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
 
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
index 1c2d2a3ecaf..19de2102a35 100644
--- 
a/flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
+++ 
b/flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
@@ -100,9 +100,12 @@ public AbstractKeyedStateBackend(
                ExecutionConfig executionConfig,
                TtlTimeProvider ttlTimeProvider) {
 
+               Preconditions.checkArgument(numberOfKeyGroups >= 1, 
"NumberOfKeyGroups must be a positive number");
+               Preconditions.checkArgument(numberOfKeyGroups >= 
keyGroupRange.getNumberOfKeyGroups(), "The total number of key groups must be 
at least the number in the key group range assigned to this backend");
+
                this.kvStateRegistry = kvStateRegistry;
                this.keySerializer = Preconditions.checkNotNull(keySerializer);
-               this.numberOfKeyGroups = 
Preconditions.checkNotNull(numberOfKeyGroups);
+               this.numberOfKeyGroups = numberOfKeyGroups;
                this.userCodeClassLoader = 
Preconditions.checkNotNull(userCodeClassLoader);
                this.keyGroupRange = Preconditions.checkNotNull(keyGroupRange);
                this.cancelStreamRegistry = new CloseableRegistry();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to