[
https://issues.apache.org/jira/browse/FLINK-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605470#comment-16605470
]
ASF GitHub Bot commented on FLINK-10283:
----------------------------------------
zentol closed pull request #6662: [FLINK-10283][runtime] Remove misleading
logging in FileCache
URL: https://github.com/apache/flink/pull/6662
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
index 0019acf6e86..041fea00fa9 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
@@ -226,7 +226,6 @@ public void releaseJob(JobID jobId, ExecutionAttemptID
executionId) {
Set<ExecutionAttemptID> jobRefCounter =
jobRefHolders.get(jobId);
if (jobRefCounter == null || jobRefCounter.isEmpty()) {
- LOG.warn("improper use of releaseJob() without
a matching number of createTmpFiles() calls for jobId " + jobId);
return;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FileCache logs unnecessary warnings
> -----------------------------------
>
> Key: FLINK-10283
> URL: https://issues.apache.org/jira/browse/FLINK-10283
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0
>
>
> When running any job the {{FileCache}} will log the following warning:
> {code}
> improper use of releaseJob() without a matching number of createTmpFiles()
> calls for jobId 7d288909946d5eb4c8d40616ad1b20d2
> {code}
> This warning is misleading as {{createTmpFiles}} is only called when the
> {{DistributedCache}} was used, but {{releaseJob}} is always called as part of
> the task cleanup routine.
> The warning should simply be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
