yanghua commented on a change in pull request #6567: [FLINK-10074] Allowable
number of checkpoint failures
URL: https://github.com/apache/flink/pull/6567#discussion_r215895305
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -875,6 +876,9 @@ public void run() {
localTaskOperatorSubtaskStates,
asyncDurationMillis);
+ if
(owner.asynchronousCheckpointExceptionHandler != null) {
Review comment:
I looked at the StreamTask, the initialization logic of the
asynchronousCheckpointExceptionHandler is in the invoke method and before the
call to the concrete init method. The invoke method has been marked as final.
So, I personally feel that we don't have to make this thing too complicated,
just to reduce a null judgment. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
