twalthr commented on a change in pull request #6579: [FLINK-10174][table] fix
getbytes in hex and toBase64
URL: https://github.com/apache/flink/pull/6579#discussion_r215946888
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
##########
@@ -221,7 +222,7 @@ object ScalarFunctions {
/**
* Returns the hex string of a string argument.
*/
- def hex(x: String): String = Hex.encodeHexString(x.getBytes).toUpperCase()
+ def hex(x: String): String =
Hex.encodeHexString(x.getBytes(Charsets.UTF_8)).toUpperCase()
Review comment:
@xueyumusic please enable more IDE checkstyles. `Charsets` is deprecated. I
will fix this while merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
