[
https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610357#comment-16610357
]
ASF GitHub Bot commented on FLINK-10223:
----------------------------------------
Clarkkkkk commented on a change in pull request #6679:
[FLINK-10223][LOG]Logging with resourceId during taskmanager startup
URL: https://github.com/apache/flink/pull/6679#discussion_r216607446
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -349,6 +349,8 @@ public static TaskExecutor startTaskManager(
checkNotNull(rpcService);
checkNotNull(highAvailabilityServices);
+ LOG.info("Starting taskManager {}", resourceID);
Review comment:
I think "Starting taskManager with ResourceID: {}, resourceID)" would be
more explicit. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TaskManagers should log their ResourceID during startup
> -------------------------------------------------------
>
> Key: FLINK-10223
> URL: https://issues.apache.org/jira/browse/FLINK-10223
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.3, 1.6.1, 1.7.0
> Reporter: Konstantin Knauf
> Assignee: aitozi
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> To debug exceptions like "org.apache.flink.util.FlinkException: The assigned
> slot <SlotId> was removed." in the master container it is often helpful to
> know, which slot was provided by which Taskmanager. The only way to relate
> slots to TaskManagers right now, seems to be to enable DEBUG logging for
> `org.apache.flink.runtime.jobmaster.slotpool.SlotPool`.
> This would be solved, if each Taskmanager would log out their `ResouceID`
> during startup as the `SlotID` mainly consists of the `ResourceID` of the
> providing Taskmanager. For Mesos and YARN the `ResourceID` has an intrinsic
> meaning, but for a stand-alone or containerized setup the `ResourceID` is
> just the a random ID.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
