NicoK commented on a change in pull request #6670: [FLINK-10301][network] 
extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances
URL: https://github.com/apache/flink/pull/6670#discussion_r216690643
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
 ##########
 @@ -96,6 +91,21 @@
 
        protected ResultPartitionID[] partitionIds;
 
+       public void setUp(
 
 Review comment:
   not really...if you don't need a custom `Configuration` object, you can 
still use this as a shortcut(?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to