[
https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610716#comment-16610716
]
ASF GitHub Bot commented on FLINK-10057:
----------------------------------------
TisonKun commented on a change in pull request #6491: [FLINK-10057] Update
FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#discussion_r216692845
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -530,6 +530,11 @@ protected Configuration
applyCommandLineOptionsToConfiguration(CommandLine comma
private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
boolean canApplyYarnProperties =
!commandLine.hasOption(addressOption.getOpt());
+ // if canApplyYarnProperties is false,return quickly !
+ if (!canApplyYarnProperties) {
+ return canApplyYarnProperties;
Review comment:
+1 to the latter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> optimalize
> org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode
> ---------------------------------------------------------------------------------
>
> Key: FLINK-10057
> URL: https://issues.apache.org/jira/browse/FLINK-10057
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.5.2
> Reporter: liuzq
> Priority: Major
> Labels: pull-request-available
>
> --------------in function :
> org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode
>
> private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
> boolean canApplyYarnProperties =
> !commandLine.hasOption(addressOption.getOpt());
> *//if canApplyYarnProperties is false,return quickly !*
> *//this code is added by me*
> *if(false==canApplyYarnProperties){*
> *return canApplyYarnProperties;*
> *}*
> for (Option option : commandLine.getOptions()) {
> if (allOptions.hasOption(option.getOpt())) {
> if (!isDetachedOption(option)) {
> ...
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
