[
https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611552#comment-16611552
]
ASF GitHub Bot commented on FLINK-10319:
----------------------------------------
TisonKun opened a new pull request #6680: [FLINK-10319] [runtime] Avoid
requestPartitionState from JM but alway…
URL: https://github.com/apache/flink/pull/6680
…s try retrigger
## What is the purpose of the change
Do not requestPartitionState from JM on partition request fail, which may
generate too many RPC requests and block JM.
We gain little benefit to check what state producer is in, which in the
other hand crash JM by too many RPC requests. Task could always
retriggerPartitionRequest from its InputGate, it would be fail if the producer
has gone and succeed if the producer alive. Anyway, no need to ask for JM for
help.
## Brief change log
Disable `JobMaster#requestPartitionState` and rewrite the logic of
`Task#triggerPartitionProducerStateCheck`. Just disable the method because a
fully clean up would shade the main changes this PR want to bring. The fully
clean up could be a follow one or the rest of this if the main proposal
approved.
## Verifying this change
`TaskTest#testReTriggerRequestPartition`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid requestPartitionState from JM but always try retrigger
> ------------------------------------------------------------
>
> Key: FLINK-10319
> URL: https://issues.apache.org/jira/browse/FLINK-10319
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.7.0
> Reporter: 陈梓立
> Assignee: 陈梓立
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Do not requestPartitionState from JM on partition request fail, which may
> generate too many RPC requests and block JM.
> We gain little benefit to check what state producer is in, which in the other
> hand crash JM by too many RPC requests. Task could always
> retriggerPartitionRequest from its InputGate, it would be fail if the
> producer has gone and succeed if the producer alive. Anyway, no need to ask
> for JM for help.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
