[
https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611902#comment-16611902
]
ASF GitHub Bot commented on FLINK-10281:
----------------------------------------
dawidwys commented on issue #6671: [FLINK-10281] [table] Fix string literal
parsing in Table & SQL API and SQL Client
URL: https://github.com/apache/flink/pull/6671#issuecomment-420601057
I've had another look after the new changes and I am ok with them as well.
One slight comment if it is not a big effort maybe split it into two commits in
that order:
1. Revert FLINK-8301
2. [FLINK-10281] [table] Fix string literal parsing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Table function parse regular expression contains backslash failed
> -----------------------------------------------------------------
>
> Key: FLINK-10281
> URL: https://issues.apache.org/jira/browse/FLINK-10281
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> for example, regular expression matches text ("\w") or number ("\d") :
> {code:java}
> testAllApis(
> "foothebar".regexExtract("foo([\\w]+)", 1), //OK, the method got
> 'foo([\w]+)'
> "'foothebar'.regexExtract('foo([\\\\w]+)', 1)", //failed, the method got
> 'foo([\\w]+)' returns "", but if pass 'foo([\\w]+)' would get compile error.
> "REGEX_EXTRACT('foothebar', 'foo([\\\\w]+)', 1)", //OK, the method got
> 'foo([\w]+)' but must pass four '\'
> "thebar"
> )
> {code}
> the "similar to" function has the same issue.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
