tzulitai commented on issue #6615: [FLINK-8354] [flink-connectors] Add ability 
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-420892843
 
 
   @alexeyt820 I think it is not easily possible to resolve the conflicts 
between this PR and #6105, which also touches the `KeyedDeserializationSchema` 
and follows a somewhat different approach.
   
   I'm also not found of wrapping the Kafka record bytes into `Record`; that 
basically always ties deserialization of the bytes with access to other meta 
information, and makes it hard to reuse some already existing deserialization 
formats such as `AvroDeserializationSchema`.
   
   Is it ok if I open a new PR that is based on this one and #6105, and see 
what I come up with? I might not be able to do that this week, but I can try 
next week.
   
   cc @FredTing would that also be ok for you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to