alexeyt820 commented on issue #6615: [FLINK-8354] [flink-connectors] Add 
ability to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#issuecomment-421014612
 
 
   @tzulitai, using ```Record``` wrapping Kafka ```ConsumerRecord``` allows to 
add for example timestamp from PR #6105 w/o need to change client code, so it 
looks like more extensible approach. Not sure how it makes hard to reuse some 
already existing deserialization formats such as 
```AvroDeserializationSchema```, at least not harder then now - 
```AvroDeserializationSchema``` will be wrapped via 
```KeyedDeserializationSchemaWrapper``` in exactly same way as know. Also 
```KeyedDeserializationSchemaWrapper``` calls only ```Record.value()```, so it 
doesn't ties deserialization of byte with access to other metadata, not in 
terms of execution path (in logical terms it is always tied because underlying 
level - Kafka ```ConsumerRecord``` contains key, value and metadata)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to