Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129570014
This test actually does not fail if the sink does not work properly. It
contains no assertions, but only prints the status.
Here are a few points that we try to follow:
- The test should assert that the correct result was produced.
- All exceptions should cause the test to fail. That means either
exceptions need to propagate out of the test method, or `Assert.fail()` needs
to be called in the catch block. Be aware that failures in spawned threads need
to be forwarded to the main thread, otherwise the unit test framework will not
work.
- Tests should not print anything, otherwise the terminal will become
unreadable during testing. Output can be made with the logging framework.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
