[
https://issues.apache.org/jira/browse/FLINK-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613562#comment-16613562
]
ASF GitHub Bot commented on FLINK-10321:
----------------------------------------
Aitozi commented on issue #6688: [FLINK-10321][network] Simplify the condition
of BroadcastPartitioner
URL: https://github.com/apache/flink/pull/6688#issuecomment-421025756
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make the condition of broadcast partitioner simple
> --------------------------------------------------
>
> Key: FLINK-10321
> URL: https://issues.apache.org/jira/browse/FLINK-10321
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.7.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> The current {{BroadcastPartitioner}} uses the vars of {{set}} and
> {{setNumber}} as the condition for returning channel arrays.
> Instead of using {{set}} and {{setNumber}}, we can just check whether
> {{returnChannel.length == numberOfOutputChannels}} as the condition to make
> it simple.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
