[
https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614614#comment-16614614
]
ASF GitHub Bot commented on FLINK-10290:
----------------------------------------
jrthe42 commented on a change in pull request #6666: [FLINK-10290] [table] Fix
conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/6666#discussion_r217662507
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamScan.scala
##########
@@ -50,11 +51,12 @@ trait StreamScan extends CommonScan[CRow] with
DataStreamRel {
f == TimeIndicatorTypeInfo.ROWTIME_STREAM_MARKER ||
f == TimeIndicatorTypeInfo.PROCTIME_STREAM_MARKER)
- if (input.getType == cRowType && !hasTimeIndicator) {
+ if (inputType == cRowType && !hasTimeIndicator) {
Review comment:
Hi @fhueske, thanks for your review.
I thought about your comment, and I found it's hard to come up with a test
case that `inputType` here is of `CRowTypeInfo`. Since only a datastream of
these types (Row, POJO, Tuple, Case class, and Atomic Type) can be registered
as a Table, the `inputType` here can never be `CRowTypeInfo`. May be we can
remove the If condition here. Correct me if I am wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Conversion error in StreamScan and BatchScan
> --------------------------------------------
>
> Key: FLINK-10290
> URL: https://issues.apache.org/jira/browse/FLINK-10290
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.5.3, 1.6.0
> Reporter: wangsan
> Assignee: wangsan
> Priority: Major
> Labels: pull-request-available
>
> `RowTypeInfo#equals()` only compares field types, and fields names are not
> considered. When checking the equality of `inputType` and `internalType`, we
> should compare both filed types and field names.
> Behavior of this bug:
> A table T with schema (a: Long, b:Long, c:Long)
> SELECT b,c,a from T
> expected: b,c,a
> actually: a,b,c
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
