zhijiangW commented on a change in pull request #6417: [FLINK-9913][runtime]
Improve output serialization only once in RecordWriter
URL: https://github.com/apache/flink/pull/6417#discussion_r217663737
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -230,7 +227,6 @@ private BufferBuilder getBufferBuilder(int targetChannel)
throws IOException, In
}
private BufferBuilder requestNewBufferBuilder(int targetChannel) throws
IOException, InterruptedException {
- checkState(!bufferBuilders[targetChannel].isPresent());
Review comment:
The calling from `getBufferBuilder` does not need this `checkState`. But for
calling from `copyFromSerializerToTargetChannel`, it may be necessary to add
this check for avoiding bugs.
I removed it just for reducing some overheads. I will restore this check. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
