twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217367243
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
##########
@@ -155,6 +156,50 @@ class Table(
select(withResolvedAggFunctionCall: _*)
}
+ /**
+ * Creates [[TemporalTableFunction]] backed up by this table as a history
table.
+ *
+ * @param timeIndicator field for the [[TemporalTableFunction]]. Must
points to a time indicator
Review comment:
As mentioned before, please add more explanation and documentation to this
method. Maybe a little example? Otherwise people won't understand/won't use
this feature. Time indicator is an internal name, use `time attribute`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
