yanghua commented on a change in pull request #6689: [FLINK-8247] [Mesos]
Support case where hadoop is not on classpath
URL: https://github.com/apache/flink/pull/6689#discussion_r217696655
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/HadoopUserOverlay.java
##########
@@ -57,24 +57,58 @@ public void configure(ContainerSpecification container)
throws IOException {
}
public static Builder newBuilder() {
- return new Builder();
+ // First check if we have Hadoop in the ClassPath. If not, we
simply don't do anything.
Review comment:
`First check if we have Hadoop in the ClassPath.` -> `First check if we have
Hadoop specific dependencies in the ClassPath.` looks better to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
