[
https://issues.apache.org/jira/browse/FLINK-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615621#comment-16615621
]
ASF GitHub Bot commented on FLINK-10215:
----------------------------------------
liuxianjiao commented on a change in pull request #6612: [FLINK-10215]Add
configuration of java option for historyserver
URL: https://github.com/apache/flink/pull/6612#discussion_r217877944
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -140,6 +140,10 @@
.key("env.java.opts.taskmanager")
.defaultValue("");
+ public static final ConfigOption<String> FLINK_HS_JVM_OPTIONS =
ConfigOptions
+ .key("env.java.opts.historyserver")
+ .defaultValue("");
Review comment:
@tillrohrmann Thanks for your review. As for the description， I think the
annotation "process parameters" in line 128 of this class already has
described “FLINK_JVM_OPTIONS”，“FLINK_JM_JVM_OPTIONS”，“FLINK_TM_JVM_OPTIONS”，as
well as our “FLINK_HS_JVM_OPTIONS”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add configuration of java option for historyserver
> ----------------------------------------------------
>
> Key: FLINK-10215
> URL: https://issues.apache.org/jira/browse/FLINK-10215
> Project: Flink
> Issue Type: Improvement
> Components: History Server
> Affects Versions: 1.6.0
> Reporter: liuxianjiao
> Assignee: liuxianjiao
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> We hava configuation to set java option for taskmanger and jobmanager, but
> there is a lack of historyserver's configuration. So, I add a
> "env.java.opts.historyserver" ,which is just like "env.java.opts.jobmanager"
> and
> "env.java.opts.taskmanager".
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
