GJL commented on a change in pull request #6706: [hotfix][doc] Fix curl example
in upload jar example
URL: https://github.com/apache/flink/pull/6706#discussion_r218560030
##########
File path:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHeaders.java
##########
@@ -73,7 +73,7 @@ public static JarUploadHeaders getInstance() {
public String getDescription() {
return "Uploads a jar to the cluster. The jar must be sent as
multi-part data. Make sure that the \"Content-Type\"" +
" header is set to \"application/x-java-archive\", as
some http libraries do not add the header by default.\n" +
- "Using 'curl' you can upload a jar via 'curl -X POST -H
\"Expect:\" -F \"jarfile=#path/to/flink-job.jar\" http://hostname:port"; + URL +
"'.";
+ "Using 'curl' you can upload a jar via 'curl -X POST -F
\"jarfile=@path/to/flink-job.jar;type=application/x-java-archive\"
http://hostname:port"; + URL + "'.";
Review comment:
`type=application/x-java-archive` does not seem to be needed. Can you
explain why it is a good idea to specify it? I would keep the `Expect` header
because I remember that it was not supported in previous versions of Flink.
Also this discussion is relevant:
https://support.urbanairship.com/hc/en-us/articles/213492003--Expect-100-Continue-Issues-and-Risks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
