[
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681771#comment-14681771
]
ASF GitHub Bot commented on FLINK-2490:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-129864531
@HuangWHWHW `retryForever` is just a convenience variable for `maxRetry <
0`. Your fix is correct because the loop will only execute if `maxRetry > 0`
and thus not execute at all if it should retry "forever". It would be great if
you added a test that checks for the correct number of retries. In case of
infinite retries, just check up to a certain number (e.g. 100 retries).
> Remove unwanted boolean check in function
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
> Key: FLINK-2490
> URL: https://issues.apache.org/jira/browse/FLINK-2490
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
