Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-129864531
@HuangWHWHW `retryForever` is just a convenience variable for `maxRetry <
0`. Your fix is correct because the loop will only execute if `maxRetry > 0`
and thus not execute at all if it should retry "forever". It would be great if
you added a test that checks for the correct number of retries. In case of
infinite retries, just check up to a certain number (e.g. 100 retries).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
