mxm closed pull request #6708: [FLINK-10358][Kinesis-connector] fix NPE in case 
millisBehindLatest is null
URL: https://github.com/apache/flink/pull/6708
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
 
b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
index 5845eea8f88..36a4e92c179 100644
--- 
a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
+++ 
b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
@@ -373,7 +373,10 @@ private GetRecordsResult getRecords(String shardItr, int 
maxNumberOfRecords) thr
                                getRecordsResult = kinesis.getRecords(shardItr, 
maxNumberOfRecords);
 
                                // Update millis behind latest so it gets 
reported by the millisBehindLatest gauge
-                               
shardMetricsReporter.setMillisBehindLatest(getRecordsResult.getMillisBehindLatest());
+                               Long millisBehindLatest = 
getRecordsResult.getMillisBehindLatest();
+                               if (millisBehindLatest != null) {
+                                       
shardMetricsReporter.setMillisBehindLatest(millisBehindLatest);
+                               }
                        } catch (ExpiredIteratorException eiEx) {
                                LOG.warn("Encountered an unexpected expired 
iterator {} for shard {};" +
                                        " refreshing the iterator ...", 
shardItr, subscribedShard);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to