[
https://issues.apache.org/jira/browse/FLINK-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622041#comment-16622041
]
ASF GitHub Bot commented on FLINK-10376:
----------------------------------------
TisonKun opened a new pull request #6721: [FLINK-10376] [tests] Replace
mkdirTolerateExisting by thread safe Files#createDirectories
URL: https://github.com/apache/flink/pull/6721
## What is the purpose of the change
Mainly to resolve the unstable test
`BlobCacheCleanupTest#testPermanentBlobCleanup`. By replace
`BlobUtils#mkdirTolerateExisting` with the same functional（but thread-safe)
method `java.nio.file.Files#createDirectories`.
## Verifying this change
Verified by passing existing tests, since it is a reinforce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> BlobCacheCleanupTest.testPermanentBlobCleanup failed on Travis
> --------------------------------------------------------------
>
> Key: FLINK-10376
> URL: https://issues.apache.org/jira/browse/FLINK-10376
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: 陈梓立
> Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.7.0
>
>
> The {{BlobCacheCleanupTest.testPermanentBlobCleanup}} failed on Travis with
> the following exception:
> {code}
> testPermanentBlobCleanup(org.apache.flink.runtime.blob.BlobCacheCleanupTest)
> Time elapsed: 1.021 sec <<< ERROR!
> java.io.IOException: Cannot create directory
> '/tmp/junit6933344779576098111/junit6230481778643276963/blobStore-77f235ff-1721-4c30-9bec-db4004fe8859/job_9ca4b9530b367af6f554dad6458ca3ad'.
> at
> org.apache.flink.runtime.blob.BlobUtils.mkdirTolerateExisting(BlobUtils.java:214)
> at
> org.apache.flink.runtime.blob.BlobUtils.getStorageLocation(BlobUtils.java:237)
> at
> org.apache.flink.runtime.blob.PermanentBlobCache.getStorageLocation(PermanentBlobCache.java:222)
> at
> org.apache.flink.runtime.blob.BlobServerCleanupTest.checkFilesExist(BlobServerCleanupTest.java:213)
> at
> org.apache.flink.runtime.blob.BlobCacheCleanupTest.verifyJobCleanup(BlobCacheCleanupTest.java:432)
> at
> org.apache.flink.runtime.blob.BlobCacheCleanupTest.testPermanentBlobCleanup(BlobCacheCleanupTest.java:133)
> {code}
> https://api.travis-ci.org/v3/job/430910115/log.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
