pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove precondition in TwoPhaseCommitSinkFunction.notif… URL: https://github.com/apache/flink/pull/6723#discussion_r219247717
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java ########## @@ -255,7 +255,6 @@ public final void notifyCheckpointComplete(long checkpointId) throws Exception { // Review comment: One thing aboved comment should be adapted: > // ==> There should never be a case where we have no pending transaction here Btw @StefanRRichter are you sure that subsuming can happen as in this test that you added? Basing on this large comment (@StephanEwen written it for pravega connector), subsuming of notification should happen on JobManager and such subsumed notification shouldn't reach the task. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services