[
https://issues.apache.org/jira/browse/FLINK-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622362#comment-16622362
]
ASF GitHub Bot commented on FLINK-10377:
----------------------------------------
pnowojski commented on a change in pull request #6723: [FLINK-10377] Remove
precondition in TwoPhaseCommitSinkFunction.notif…
URL: https://github.com/apache/flink/pull/6723#discussion_r219247717
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
##########
@@ -255,7 +255,6 @@ public final void notifyCheckpointComplete(long
checkpointId) throws Exception {
//
Review comment:
One thing aboved comment should be adapted:
> // ==> There should never be a case where we have no pending
transaction here
Btw @StefanRRichter are you sure that subsuming can happen as in this test
that you added? Basing on this large comment (@StephanEwen written it for
pravega connector), subsuming of notification should happen on JobManager and
such subsumed notification shouldn't reach the task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove precondition in TwoPhaseCommitSinkFunction.notifyCheckpointComplete
> --------------------------------------------------------------------------
>
> Key: FLINK-10377
> URL: https://issues.apache.org/jira/browse/FLINK-10377
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
>
> The precondition {{checkState(pendingTransactionIterator.hasNext(),
> "checkpoint completed, but no transaction pending");}} in
> {{TwoPhaseCommitSinkFunction.notifyCheckpointComplete()}} seems too strict,
> because checkpoints can overtake checkpoints and will fail the precondition.
> In this case the commit was already performed by the first notification and
> subsumes the late checkpoint. I think the check can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
