[
https://issues.apache.org/jira/browse/FLINK-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622488#comment-16622488
]
ASF GitHub Bot commented on FLINK-10383:
----------------------------------------
StephanEwen opened a new pull request #6728: [FLINK-10383] [s3] (release-1.6)
Prevent Hadoop configs on classpath to interfere with S3 configuration
URL: https://github.com/apache/flink/pull/6728
## What is the purpose of the change
The S3 connectors are based on a self-contained shaded Hadoop. By design,
they should only use config value from the Flink configuration.
However, because Hadoop loads implicitly configs from the classpath,
existing "core-site.xml" files can interfere with the configuration in ways
in-transparent for the user.
This PR ensure such configs are not loaded.
## Brief change log
- The testing configs are renamed to "core-default-testing.xml"
- The shaded adjusted config loading ignores "core-site.xml" files but
loads "core-default-testing.xml" files
## Verifying this change
- Includes a test by adding an improper "core-site.xml" to the test class
path. If that file was loaded, the existing tests would fail.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **yes**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **no**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hadoop configurations on the classpath seep into the S3 file system configs
> ---------------------------------------------------------------------------
>
> Key: FLINK-10383
> URL: https://issues.apache.org/jira/browse/FLINK-10383
> Project: Flink
> Issue Type: Bug
> Components: FileSystem
> Affects Versions: 1.6.1
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2
>
>
> The S3 connectors are based on a self-contained shaded Hadoop. By design,
> they should only use config value from the Flink configuration.
> However, because Hadoop loads implicitly configs from the classpath, existing
> "core-site.xml" files can interfere with the configuration in ways
> intransparent for the user. We should ensure such configs are not loaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
