[
https://issues.apache.org/jira/browse/FLINK-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623196#comment-16623196
]
陈梓立 edited comment on FLINK-10385 at 9/21/18 7:36 AM:
------------------------------------------------------
Maybe a waiting utils based on {{sleep}} and test would lose state changes
quite quickly. Is it reasonable to use {{CountDownLatch}} or {{OneShotLatch}}
at this case? If so, then there is a guideline and we can refactor tests
gradually.
But well, some cases might not easy to inject a latch.
was (Author: tison):
Maybe a waiting utils based on {{sleep}} and test would lose state changes
quite quickly. Is it reasonable to use {{CountDownLatch}} or {{OneShotLatch}}
at this case? If so, then there is a guideline and we can refactor tests
gradually.
> Implement a waitUntilCondition utils
> ------------------------------------
>
> Key: FLINK-10385
> URL: https://issues.apache.org/jira/browse/FLINK-10385
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: 陈梓立
> Priority: Major
> Fix For: 1.7.0
>
> Attachments: example.java
>
>
> Recently when I refine some tests, I notice that it is a common requirement
> to wait until a (stable) condition occur.
> To achieve this, we have {{ExecutionGraphTestUtils#waitUntilJobStatus}} and
> many. Most of them can simply abstract as
> {code:java}
> public static void waitUntilCondition(SupplierWithException<Boolean,
> Throwable> conditionSupplier, Deadline deadline) {
> while (deadline.hasTimeLeft()) {
> if (conditionSupplier.get()) { return; }
> Thread.sleep(Math.min(deadline.toMillis(), 500);
> }
> throws new IlleagalStateException("...");
> }
> {code}
>
> I propose to implement such a method to avoid too many utils method scattered
> to achieve the same purpose.
> Looking forward to your advice. If there is previous code/project already
> implemented this, I am glad to introduce it.
> cc [~Zentol]
>
> PS: the file attached is some code I found could satisfy this proposal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
