[
https://issues.apache.org/jira/browse/FLINK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623422#comment-16623422
]
ASF GitHub Bot commented on FLINK-10310:
----------------------------------------
wittyameta opened a new pull request #6732: [FLINK-10310] Cassandra Sink -
Handling failing requests.
URL: https://github.com/apache/flink/pull/6732
## What is the purpose of the change
This pull request provides support to optionally handle cassandra sink
errors. A user may choose to ignore an exception instead of allowing the sink
to fail. The handler is similar to `ActionRequestFailureHandler` in Elastic
Sink.
## Brief change log
- *Added interface `CassandraFailureHandler` and a no-op implementation
`NoOpCassandraFailureHandler`*
- *`CassandraSinkBase` has a new field `failureHandler` and updated
constructor*
- *`checkAsyncErrors` method in `CassandraSinkBase` calls the
`failureHandler` instead of throwing an `IOException`*
- *`CassandraSinkBuilder` has a new optional field `failureHandler` and
updated setter. Uses no-op implementation as default*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test in class `CassandraSinkBaseTest` that validates that
failureHandler is called and the error is ignored*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **yes**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **yes**
- If yes, how is the feature documented? **docs**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cassandra Sink - Handling failing requests
> ------------------------------------------
>
> Key: FLINK-10310
> URL: https://issues.apache.org/jira/browse/FLINK-10310
> Project: Flink
> Issue Type: Improvement
> Components: Cassandra Connector
> Reporter: Jayant Ameta
> Priority: Major
> Labels: pull-request-available
>
> The cassandra sink fails for any kind of error. For some exceptions (e.g
> WriteTimeoutException), ignoring the exception may be acceptable as well.
> Can we discuss having a FailureHandler on the lines ofÂ
> ActionRequestFailureHandler?
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/WriteTimeoutException-in-Cassandra-sink-kill-the-job-tp22706p22707.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
