[
https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623707#comment-16623707
]
ASF GitHub Bot commented on FLINK-9682:
---------------------------------------
dawidwys commented on a change in pull request #6266: [FLINK-9682] Add
setDescription to execution environment and provide description field for the
rest api
URL: https://github.com/apache/flink/pull/6266#discussion_r219476983
##########
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plan/OptimizedPlan.java
##########
@@ -49,23 +49,28 @@
/** Name of the job */
private final String jobName;
+ /** Descrption of the job */
+ private final String jobDescription;
+
/**
* Creates a new instance of this optimizer plan container. The plan is
given and fully
* described by the data sources, sinks and the collection of all nodes.
- *
+ *
* @param sources The data sources.
* @param sinks The data sinks.
* @param allNodes A collection containing all nodes in the plan.
* @param jobName The name of the program
+ * @param jobDescription The description of the program
*/
public OptimizedPlan(Collection<SourcePlanNode> sources,
Collection<SinkPlanNode> sinks,
- Collection<PlanNode> allNodes, String jobName, Plan
programPlan)
+ Collection<PlanNode> allNodes,
String jobName, Plan programPlan, String jobDescription)
Review comment:
Actually I would remove the `jobName` and `jobDescription` parameters, and
use those values from the programPlan, which we always do anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add setDescription to execution environment and provide description field for
> the rest api
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-9682
> URL: https://issues.apache.org/jira/browse/FLINK-9682
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API, Webfrontend
> Affects Versions: 1.5.0
> Reporter: Elias Levy
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> Currently you can provide a job name to {{execute}} in the execution
> environment. In an environment where many version of a job may be executing,
> such as a development or test environment, identifying which running job is
> of a specific version via the UI can be difficult unless the version is
> embedded into the job name given the {{execute}}. But the job name is uses
> for other purposes, such as for namespacing metrics. Thus, it is not ideal
> to modify the job name, as that could require modifying metric dashboards and
> monitors each time versions change.
> I propose a new method be added to the execution environment,
> {{setDescription}}, that would allow a user to pass in an arbitrary
> description that would be displayed in the dashboard, allowing users to
> distinguish jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
