azagrebin commented on issue #6567: [FLINK-10074] Allowable number of 
checkpoint failures
URL: https://github.com/apache/flink/pull/6567#issuecomment-423942772
 
 
   > Do we need to take this refactoring into account? Because this PR is 
actually a supplement to the checkpoint exception handler.
   
   Yes, I think we can have the same semantics as in the previous only-TM 
implementation (`setFailOnCheckpointingErrors` means `tolerableFailures == 0`) 
but now everything should happen in `CheckpointCoordinator`. That is why I also 
mentioned this point:
   
   > Consider having only DecliningCheckpointExceptionHandler on TaskExecutor 
side and letting now to handle all failure cases only in CheckpointCoordinator
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to