[
https://issues.apache.org/jira/browse/FLINK-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625708#comment-16625708
]
ASF GitHub Bot commented on FLINK-10389:
----------------------------------------
yanghua opened a new pull request #6740: [FLINK-10389]
TaskManagerServicesConfiguration ctor contains self assignment
URL: https://github.com/apache/flink/pull/6740
## What is the purpose of the change
*This pull request fixed TaskManagerServicesConfiguration ctor contains
self assignment*
## Brief change log
- *Removed the self assignment statement*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TaskManagerServicesConfiguration ctor contains self assignment
> --------------------------------------------------------------
>
> Key: FLINK-10389
> URL: https://issues.apache.org/jira/browse/FLINK-10389
> Project: Flink
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> TaskManagerServicesConfiguration has:
> {code}
> this.systemResourceMetricsEnabled = systemResourceMetricsEnabled;
> {code}
> There is no systemResourceMetricsEnabled parameter to the ctor.
> This was reported by findbugs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
