[
https://issues.apache.org/jira/browse/FLINK-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625966#comment-16625966
]
ASF GitHub Bot commented on FLINK-10393:
----------------------------------------
TisonKun commented on a change in pull request #6745: [FLINK-10393] Remove
legacy entrypoints from start up scripts
URL: https://github.com/apache/flink/pull/6745#discussion_r219876929
##########
File path: flink-dist/src/main/flink-bin/bin/taskmanager.sh
##########
@@ -34,11 +34,7 @@ bin=`cd "$bin"; pwd`
. "$bin"/config.sh
-TYPE=taskmanager
-
-if [[ "${FLINK_MODE}" == "new" ]]; then
- TYPE=taskexecutor
-fi
+ENTRYPOINT=taskexecutor
Review comment:
nice change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove legacy entrypoints from startup scripts
> ----------------------------------------------
>
> Key: FLINK-10393
> URL: https://issues.apache.org/jira/browse/FLINK-10393
> Project: Flink
> Issue Type: Sub-task
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments:
> 0001-FLINK-10393-Remove-legacy-entrypoints-from-startup-s.patch
>
>
> Remove the legacy entrypoints from the startup scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
