[
https://issues.apache.org/jira/browse/FLINK-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626106#comment-16626106
]
ASF GitHub Bot commented on FLINK-10295:
----------------------------------------
azagrebin opened a new pull request #6754: [FLINK-10295] Add support of passing
jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754
## What is the purpose of the change
This PR add one more option to specify jar program arguments in REST API
calls (run and get plan). Users can specify arguments as one string or
additionally mow as a list of a separate strings.
## Brief change log
- add JarRequestBody as a base for JarRunRequestBody and JarPlanRequestBody
- add programArgsList to JarRequestBody
- add JarHandlerUtils.getProgramArgs to resolve program args from
programArgs and programArgsList from query path or json body in JarRunHandler
or JarPlanHandler
- user can use programArgs or programArgsList but not both, add test for it
## Verifying this change
Unit tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Tokenisation of Program Args resulting in unexpected results
> ------------------------------------------------------------
>
> Key: FLINK-10295
> URL: https://issues.apache.org/jira/browse/FLINK-10295
> Project: Flink
> Issue Type: Bug
> Components: REST, Webfrontend
> Affects Versions: 1.5.0, 1.6.0, 1.7.0
> Reporter: Gaurav Singhania
> Assignee: Andrey Zagrebin
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments: sample_request.txt
>
>
> We were upgrading from Flink 1.4 to 1.6. At present we have a jar which takes
> all the details to run the job as program args against a jarid, including sql
> query and kafka details. In version 1.5 the program args are tokenised as a
> result single quote (') and double quote(") are stripped from the arguments.
> This results in malformed args.
> Attached a sample request for reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
