[
https://issues.apache.org/jira/browse/FLINK-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627113#comment-16627113
]
ASF GitHub Bot commented on FLINK-9455:
---------------------------------------
azagrebin commented on a change in pull request #6734: [FLINK-9455][RM] Add
support for multi task slot TaskExecutors
URL: https://github.com/apache/flink/pull/6734#discussion_r220133632
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
##########
@@ -544,21 +544,17 @@ public void
testDuplicatePendingSlotRequestAfterSuccessfulAllocation() throws Ex
@Test
public void testAcceptingDuplicateSlotRequestAfterAllocationRelease()
throws Exception {
final ResourceManagerId resourceManagerId =
ResourceManagerId.generate();
- final ResourceActions resourceManagerActions =
mock(ResourceActions.class);
+ final AtomicInteger allocateResourceCalls = new
AtomicInteger(0);
+ final ResourceActions resourceManagerActions = new
TestingResourceActionsBuilder()
+ .setAllocateResourceConsumer(resourceProfile ->
allocateResourceCalls.incrementAndGet())
Review comment:
the logic of some of this built TestingResourceActions repeat in some
places, we could create some standard factory methods for them (maybe in
future), e.g.:
```
resourceManagerActions =
TestingResourceActionsBuilder.createAllocatingFixedSlotsResource(numOfSlotsPerWorker);
allocateResourceCalls = resourceManagerActions.getAllocationsCounter();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make SlotManager aware of multi slot TaskManagers
> -------------------------------------------------
>
> Key: FLINK-9455
> URL: https://issues.apache.org/jira/browse/FLINK-9455
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, ResourceManager
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The {{SlotManager}} responsible for managing all available slots of a Flink
> cluster can request to start new {{TaskManagers}} if it cannot fulfill a slot
> request. The started {{TaskManager}} can be started with multiple slots
> configured but currently, the {{SlotManager}} thinks that it will be started
> with a single slot. As a consequence, it might issue multiple requests to
> start new TaskManagers even though a single one would be sufficient to
> fulfill all pending slot requests.
> In order to avoid requesting unnecessary resources which are freed after the
> idle timeout, I suggest to make the {{SlotManager}} aware of how many slots a
> {{TaskManager}} is started with. That way the SlotManager only needs to
> request a new {{TaskManager}} if all of the previously started slots
> (potentially not yet registered and, thus, future slots) are being assigned
> to slot requests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
