[
https://issues.apache.org/jira/browse/FLINK-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627386#comment-16627386
]
ASF GitHub Bot commented on FLINK-10411:
----------------------------------------
StefanRRichter commented on a change in pull request #6743: [FLINK-10411] Make
ClusterEntrypoint more compositional
URL: https://github.com/apache/flink/pull/6743#discussion_r220127856
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/entrypoint/MesosJobClusterEntrypoint.java
##########
@@ -179,7 +111,15 @@ protected JobGraph retrieveJobGraph(Configuration
configuration) throws FlinkExc
}
@Override
- protected void
registerShutdownActions(CompletableFuture<ApplicationStatus> terminationFuture)
{}
+ protected ClusterComponent<?> createClusterComponent(Configuration
configuration) {
+ return new JobClusterComponent(
+ new MesosResourceManagerFactory(
+ mesosServices,
+ schedulerConfiguration,
+ taskManagerParameters,
+ taskManagerContainerSpec),
+ new
FileJobGraphRetriever(configuration.getString(JOB_GRAPH_FILE_PATH,
"job.graph")));
Review comment:
We could use a helper method that does construct `FileJobGraphRetriever`
from `configuration` because this is duplicated. At least `"job.graph"` could
become a string constant somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make ClusterEntrypoint more modular
> -----------------------------------
>
> Key: FLINK-10411
> URL: https://issues.apache.org/jira/browse/FLINK-10411
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Currently, the {{ClusterEntrypoint}} is not very modular in the sense that it
> cannot be really used for testing purposes (e.g. starting a {{Dispatcher}}
> with a {{WebMonitorRestEndpoint}}). The problem is that the
> {{ClusterEntrypoint}} combines too many responsibilities (creating the
> cluster services, starting the cluster components and deciding on when to
> terminate the JVM process).
> I suggest to make the structure more compositional, meaning to split up the
> service generation from the cluster component start up. That way we could
> also remove code duplication between the different {{ClusterEntrypoint}}
> implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
