StefanRRichter commented on a change in pull request #6749: [FLINK-10401] Port
ProcessFailureCancelingITCase to new code base
URL: https://github.com/apache/flink/pull/6749#discussion_r220205505
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterComponent.java
##########
@@ -130,6 +131,13 @@ public T getDispatcher() {
}
}
+ @VisibleForTesting
+ public WebMonitorEndpoint<?> getWebMonitorEndpoint() {
Review comment:
Coming back to my longer comment on #6749, I think this is only required
because the collaborator is lazily created in a lifecycle method. I wonder if
we could not have a building object the will create all collaborators at the
place where currently `startComponent` is called because `clusterComponent =
createClusterComponent(configuration)` and
`clusterComponent.startComponent(...)` are even called in a straight sequence.
Tests could then simply pass WebMonitorEndpoint into the component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
