[
https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628928#comment-16628928
]
ASF GitHub Bot commented on FLINK-10436:
----------------------------------------
StefanRRichter commented on a change in pull request #6767: [FLINK-10436]
Example config uses deprecated key jobmanager.rpc.address
URL: https://github.com/apache/flink/pull/6767#discussion_r220608342
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -30,7 +30,7 @@
# automatically configure the host name based on the hostname of the node
where the
# JobManager runs.
-jobmanager.rpc.address: localhost
+rest.address: localhost
Review comment:
Wouldn't it make sense to also change `jobmanager.rpc.port` to `rest.port`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Example config uses deprecated key jobmanager.rpc.address
> ---------------------------------------------------------
>
> Key: FLINK-10436
> URL: https://issues.apache.org/jira/browse/FLINK-10436
> Project: Flink
> Issue Type: Bug
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Ufuk Celebi
> Assignee: tison
> Priority: Major
> Labels: pull-request-available
>
> The example {{flink-conf.yaml}} shipped as part of the Flink distribution
> (https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml)
> has the following entry:
> {code}
> jobmanager.rpc.address: localhost
> {code}
> When using this key, the following deprecation warning is logged.
> {code}
> 2018-09-26 12:01:46,608 WARN org.apache.flink.configuration.Configuration
> - Config uses deprecated configuration key
> 'jobmanager.rpc.address' instead of proper key 'rest.address'
> {code}
> The example config should not use deprecated config options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
