[
https://issues.apache.org/jira/browse/FLINK-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630277#comment-16630277
]
ASF GitHub Bot commented on FLINK-3875:
---------------------------------------
dawidwys commented on a change in pull request #6611: [FLINK-3875] [connectors]
Add an upsert table sink factory for Elasticsearch
URL: https://github.com/apache/flink/pull/6611#discussion_r220885858
##########
File path: docs/dev/table/connect.md
##########
@@ -621,7 +621,7 @@ The connector operates in [upsert mode](#update-modes) and
exchanges UPSERT/DELE
// optional: configure how to buffer elements before sending them in bulk
to the cluster for efficiency
.disableFlushOnCheckpoint() // optional: disables flushing on
checkpoint (see notes below!)
.bulkFlushMaxActions(42) // optional: maximum number of actions to
buffer for each bulk request
- .bulkFlushMaxSize(42) // optional: maximum size of buffered
actions (in MB) per bulk request
+ .bulkFlushMaxSize("42 mb") // optional: maximum size of buffered
actions (in MB) per bulk request
Review comment:
It is no longer `(in MB)`, by default if no unit is provided it will be
treated as bytes. I would also add info about the minimal restriction here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add a TableSink for Elasticsearch
> ---------------------------------
>
> Key: FLINK-3875
> URL: https://issues.apache.org/jira/browse/FLINK-3875
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors, Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> Add a TableSink that writes data to Elasticsearch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
