tillrohrmann commented on a change in pull request #6763: [FLINK-10415] Fail
response future if connection closes in RestClient
URL: https://github.com/apache/flink/pull/6763#discussion_r220936090
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java
##########
@@ -339,12 +338,26 @@ private static Request createRequest(String
targetAddress, String targetUrl, Htt
.thenComposeAsync(
channel -> {
ClientHandler handler =
channel.pipeline().get(ClientHandler.class);
- CompletableFuture<JsonResponse> future
= handler.getJsonFuture();
+
+ CompletableFuture<JsonResponse> future;
+ boolean success = false;
+
try {
- httpRequest.writeTo(channel);
+ if (handler == null) {
Review comment:
No not really. It happened from time to time when running the
`RestClientTest#testConnectionClosedHandling` in a loop. It might be a Netty
bug but we should guard against this in order to harden the test case. I don't
think that something bad happens if we fail the request with an `IOException`
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
