Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/992#discussion_r36955189
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
 ---
    @@ -40,10 +37,12 @@
        private char delimiter;
        private long maxRetry;
        private boolean retryForever;
    +   private boolean isRetrying = false;
        private Socket socket;
        private static final int CONNECTION_TIMEOUT_TIME = 0;
        private static final int CONNECTION_RETRY_SLEEP = 1000;
     
    +   private volatile boolean isExit = false;
    --- End diff --
    
    Is this flag necessary? We have `isRunning` already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to