yanghua commented on a change in pull request #6759: [FLINK-10247][Metrics] Run
MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r221155740
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -87,11 +89,35 @@
* @return The ActorSystem which has been started
* @throws Exception
*/
+ public static ActorSystem startActorSystem(
+ Configuration configuration,
+ String listeningAddress,
+ String portRangeDefinition,
+ Logger logger) throws Exception {
+ return startActorSystem(
+ configuration,
+ listeningAddress,
+ portRangeDefinition,
+ logger,
+ AkkaExecutorMode.FORK_JOIN_EXECUTOR);
+ }
+
+ /**
+ * Starts an ActorSystem with the given configuration listening at the
address/ports.
+ * @param configuration The Flink configuration
Review comment:
insert a empty line before the first `@param`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
