[
https://issues.apache.org/jira/browse/FLINK-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633413#comment-16633413
]
tison commented on FLINK-10468:
-------------------------------
I just have taken a look at that code and think it is intended since
{{PARTITION_CUSTOM}} means that partitioning using a custom partitioner so it
sets a {{extractedKeys}}, but all of the strategy need a {{channels}}.
However, I am not quite familiar with this code and think [~zjwang],
[~piwaniuk] and [~NicoK] would know more about it. And if they are stand the
same way as me, we can close this issue as won't fix.
> Potential missing break for PARTITION_CUSTOM in OutputEmitter ctor
> ------------------------------------------------------------------
>
> Key: FLINK-10468
> URL: https://issues.apache.org/jira/browse/FLINK-10468
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> Here is related code:
> {code}
> switch (strategy) {
> case PARTITION_CUSTOM:
> extractedKeys = new Object[1];
> case FORWARD:
> {code}
> It seems a 'break' is missing prior to FORWARD case.
> {code}
> if (strategy == ShipStrategyType.PARTITION_CUSTOM && partitioner == null)
> {
> throw new NullPointerException("Partitioner must not be null when the
> ship strategy is set to custom partitioning.");
> }
> {code}
> Since the above check is for PARTITION_CUSTOM, it seems we can place the
> check in the switch statement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
