zentol commented on a change in pull request #6731: [FLINK-10312] Propagate
exception from server to client in REST API
URL: https://github.com/apache/flink/pull/6731#discussion_r221546026
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
##########
@@ -207,12 +210,10 @@
resultFuture.whenComplete(
(innerT, innerThrowable) -> scheduledFuture.cancel(false));
} else {
- final String
errorMsg = retries == 0 ?
- "Number
of retries has been exhausted." :
-
"Exception is not retryable.";
-
resultFuture.completeExceptionally(new RetryException(
- "Could
not complete the operation. " + errorMsg,
-
throwable));
+ RetryException
retryException = new RetryException(
+ "Could
not complete the operation: number of retries has been exhausted.",
Review comment:
I would stick with the original formatting: `Could not complete the
operation. Number of retries has been exhausted.`
When seeing a `:` I would expect a reason as to _why_ it couldn't be
completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
