[
https://issues.apache.org/jira/browse/FLINK-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635467#comment-16635467
]
ASF GitHub Bot commented on FLINK-10292:
----------------------------------------
tillrohrmann commented on a change in pull request #6786: [FLINK-10292][rest]
Separate REST and Dispatcher RPC thread pools
URL: https://github.com/apache/flink/pull/6786#discussion_r221943598
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -714,6 +717,7 @@ public void startInternal() throws Exception {
@Override
protected CompletableFuture<Void> shutDownInternal() {
executionGraphCache.close();
+ ExecutorUtils.gracefulShutdown(10, TimeUnit.SECONDS, executor);
Review comment:
I think we should shut down the `executor` after shutting down the handlers.
Otherwise we might run into the situation that a handler tries to add something
to a closed `Executor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generate JobGraph in StandaloneJobClusterEntrypoint only once
> -------------------------------------------------------------
>
> Key: FLINK-10292
> URL: https://issues.apache.org/jira/browse/FLINK-10292
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2
>
>
> Currently the {{StandaloneJobClusterEntrypoint}} generates the {{JobGraph}}
> from the given user code every time it starts/is restarted. This can be
> problematic if the the {{JobGraph}} generation has side effects. Therefore,
> it would be better to generate the {{JobGraph}} only once and store it in HA
> storage instead from where to retrieve.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
