tillrohrmann commented on issue #6786: [FLINK-10292][rest] Separate REST and 
Dispatcher RPC thread pools
URL: https://github.com/apache/flink/pull/6786#issuecomment-426639274
 
 
   Thanks for addressing some of my components @zentol. I think we should still 
change how the `ExecutorService` is instantiated. Instead of doing it in the 
constructor it should happen imo outside of the component. That way, we don't 
couple different components (e.g. which `ExecutorService` is used by the 
`WebMonitorEndpoint`). Moreover, it was already like this before and, thus, we 
would introduce a regression (in terms of architecture). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to